Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chat events #299

Open
wants to merge 2 commits into
base: 1.19
Choose a base branch
from
Open

Fix chat events #299

wants to merge 2 commits into from

Conversation

shedaniel
Copy link
Member

  • This fixes chat events on fabric due to Fabric API taking priority above our mixins, we inject to the same place
  • Test mod now with appended "new text" for server chat modifications and "error:" for client chat modifications
  • Forge event now not cancelled for client chat modifications

@shedaniel shedaniel added bug Something isn't working testmod This pull request contains a testmod priority: high This needs to be worked on and reviewed ASAP 1.19 This issue applies to Minecraft 1.19. labels Jul 16, 2022
@ChiefArug ChiefArug mentioned this pull request Jul 19, 2022
Closed
@MaxNeedsSnacks
Copy link
Member

Superseded by #302

@shedaniel shedaniel reopened this Aug 6, 2022
@shedaniel
Copy link
Member Author

We still need this

@MaxNeedsSnacks
Copy link
Member

In that case, see my comments regarding the cancelling component ^^ There has to be a better way to do that :/

@MaxNeedsSnacks
Copy link
Member

Please resolve the merge conflicts so this can be put on last call

@MaxNeedsSnacks
Copy link
Member

Is there still enough demand for 1.19 to warrant fixing this issue? The discourse(TM) regarding that version has largely died down, and due to CurseForge's horrible UX I would even say that publishing a new 1.19.0 release would likely confuse users into downloading said new version for their 1.19.2 instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxNeedsSnacks MaxNeedsSnacks MaxNeedsSnacks approved these changes

Assignees
No one assigned
Labels
1.19 This issue applies to Minecraft 1.19. bug Something isn't working priority: high This needs to be worked on and reviewed ASAP testmod This pull request contains a testmod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shedaniel @MaxNeedsSnacks