fix: pin glob
to version that's compatible with Node.js <14.18
#185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Big fan of
archiver
. We've tracked down a small bug around compatibility with Node.js v14, specifically on versions before 14.18.In isaacs/node-glob@435d1f7, the dependency
glob
started usingnode:
-prefixed imports, which is only supported starting from Node 14.18. When usingarchiver
on prior versions, it throwsSince archiver intends to support all of Node v14, the fix is to pin
glob
to the last version without that change. That's what this PR does.An alternative solution would be to drop support for
v14
altogether, but personally i'd prefer keeping some compatibility.