[4.x] Clean up expired impersonation tokens instead of just aborting, add command for cleaning up expired tokens #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1387 +/- ##
============================================
+ Coverage 85.95% 86.01% +0.06%
- Complexity 1098 1102 +4
============================================
Files 178 179 +1
Lines 3204 3218 +14
============================================
+ Hits 2754 2768 +14
Misses 450 450 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stancl
reviewed
Aug 25, 2025
Comment on lines
+11
to
+14
| * This command clears expired impersonation tokens. | ||
| * By default, all tokens older than UserImpersonation::$ttl (60 seconds by default) | ||
| * are deleted. To override this, you can use the --ttl option, for example | ||
| * --ttl=120, all tokens older than 120 seconds will be deleted, ignoring the default. |
There was a problem hiding this comment.
Is there a use case for wanting to keep expired tokens?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the expired/invalid tenant impersonation tokens get deleted instead of just aborting with 403.
The PR also adds a command (ClearExpiredImpersonationTokens) used like
php artisan tenants:clear-expired-impersonation-tokens. As the name suggests, it clears all expired impersonation tokens. By default, all tokens older thanUserImpersonation::$ttlare deleted, but you can pass the--ttl=Xoption to override this (e.g. php artisan tenants:clear-expired-impersonation-tokens --ttl=10` will delete all tokens older than 10 seconds.Resolves #1348