-
Notifications
You must be signed in to change notification settings - Fork 7
docs: add docs on Client IP #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
wooorm-arcjet
wants to merge
13
commits into
main
Choose a base branch
from
wooorm/client-ip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
We decided to hold this until the Proxy work has been completed so I'm going to move to a draft for now. |
wooorm-arcjet
added a commit
that referenced
this pull request
Dec 5, 2025
Related-to: GH-704. Related-to: ENG-127.
This is based on current workings, with additions of how it *could* work, marked with visible TODOs, linking to issues in `arcjet/arcjet-js`. This introduces a new “Concepts” section. Some users want to get started, some want to see Arcjets features, but some come in with a problem around a particular “topic”. I hope to put stuff like “Environment variables”, “Request body”, “Fingerprints”, and such typically finicky stuff under here. I explicitly want these a bit higher that “Advanced”, to not dissuade folks. But that’s where I want to go and as this is the lonely first, open to have it somewhere else. (note: not draft because I explicitly want to hear thoughts) Closes GH-703.
41cb255 to
d16f513
Compare
wooorm-arcjet
added a commit
that referenced
this pull request
Dec 8, 2025
Related-to: GH-704. Related-to: ENG-127.
wooorm-arcjet
added a commit
that referenced
this pull request
Dec 11, 2025
Related-to: GH-704. Related-to: ENG-127.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on current workings, with additions of how it could work, marked with visible TODOs, linking to issues in
arcjet/arcjet-js.This introduces a new “Concepts” section.
Some users want to get started, some want to see Arcjets features, but some come in with a problem around a particular “topic”. I hope to put stuff like “Environment variables”, “Request body”, “Fingerprints”, and such typically finicky stuff under here. I explicitly want these a bit higher that “Advanced”, to not dissuade folks.
But that’s where I want to go and as this is the lonely first, open to have it somewhere else.
(note: not draft because I explicitly want to hear thoughts)
Closes GH-703.