chore(playwright): introduce playwright & screenshot test #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
wooorm-arcjet
approved these changes
Dec 10, 2025
Member
wooorm-arcjet
left a comment
wooorm-arcjet
left a comment
There was a problem hiding this comment.
looks good to me, not sure if you want someone else to review too.
as you say, we can always tweak later!
qw-in
deleted the
quinn/eng-201-introduce-playwright-for-baseline-integration-testing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I've introduced Playwright & some screenshot testing. My hope is that as I (we) start to make changes this is a relatively low-effort way to guarantee I don't introduce regressions. It remains to be seen if the screenshots will help or just get in the way!
I'd like to try this for a while and at least see how useful/painful it is. I've tried my best to tune it to run in a reasonable time and not have too many false positives but time will tell.
If it seems like its a positive change, we could look at making it a required test, running against the vercel preview, etc.
If we don't like the screenshot test I can rip that out of this PR. It just seemed difficult to validate the playwright configuration and GitHub action without a test that does something.
cc @davidmytton @wooorm-arcjet as you both are working here quite regularly!
Closes ENG-201