chore: refactor pattern and instances fields #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-moran
force-pushed
the
eoin/refactor-pattern-instances
branch
from
5c69f0e to
d9d67a5
Compare
Comment on lines
+9
to
+12
| "accepted": [ | ||
| "Googlebot\\/" | ||
| ], | ||
| "forbidden": [] |
There was a problem hiding this comment.
I liked accepted and forbidden for instances, but why did you use it here instead of include and exclude patterns.
There was a problem hiding this comment.
I just think that they're a little bit clearer. I read it like "accept UAs that have these patterns" and "forbid UAs that have these patterns". I'm open to suggestions though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37