Skip to content
This repository has been archived by the owner on Aug 27, 2024. It is now read-only.

chore(build): Provide multiple build jobs. Closes #150 #153

Merged
merged 12 commits into from
Dec 18, 2021

Conversation

SamVanhoutte
Copy link
Contributor

Add multiple stages & jobs:

  • Prerequisites
  • UnitTests
  • PackageAndRelease

@netlify
Copy link

netlify bot commented Dec 9, 2021

✔️ Deploy Preview for arcus-azureml ready!

🔨 Explore the source changes: 4261488

🔍 Inspect the deploy log: https://app.netlify.com/sites/arcus-azureml/deploys/61bc7037d0ce940007a65039

😎 Browse the preview: https://deploy-preview-153--arcus-azureml.netlify.app

@SamVanhoutte
Copy link
Contributor Author

Build seems to fail, because of dependencies installed in first stage, not being found in the second stage.
Is this because they could be seperate machines?

image

@SamVanhoutte SamVanhoutte added automation All issues related to project automation enhancement New feature or request labels Dec 9, 2021
@SamVanhoutte SamVanhoutte linked an issue Dec 9, 2021 that may be closed by this pull request
@stijnmoreels
Copy link
Member

stijnmoreels commented Dec 10, 2021

Build seems to fail, because of dependencies installed in first stage, not being found in the second stage. Is this because they could be seperate machines?

image

Yeah, but if you can install them locally into a build artifact you can pass along them to the next stage. Our other Arcus repo's all have this approach. We'll see.

Copy link
Member

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have some more separation and consistency with the Arcus repo's. I'm wondering if the other Python ML package uses the same (almost the same) setup for building; and if so, we could move it to our general Azure DevOps YAML templates repo instead of manually having all the script commands here.

Also, we should update the release pipeline too, right?

@SamVanhoutte
Copy link
Contributor Author

@stijnmoreels release build is updated.
Issues arcus-azure/azure-devops-templates#50 and arcus-azure/azure-devops-templates#51 created for the template generation

@stijnmoreels
Copy link
Member

@stijnmoreels release build is updated. Issues arcus-azure/azure-devops-templates#50 and arcus-azure/azure-devops-templates#51 created for the template generation

Great! 👍

@stijnmoreels
Copy link
Member

We can always look further into why the build and tests jobs needs to be in the same stage, but for a first run, I think this is good. @ALaks96 , what do you think?

Copy link
Member

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first improvement on this 💯

@SamVanhoutte SamVanhoutte merged commit 42c701e into master Dec 18, 2021
@SamVanhoutte SamVanhoutte deleted the build-multi-jobs branch December 18, 2021 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation All issues related to project automation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split CI build in separate jobs for clearer overview and restart
3 participants