Skip to content

chore: add net8.0 preview support#537

Merged
stijnmoreels merged 31 commits intoarcus-azure:mainfrom
stijnmoreels:chore/add-net8.0-preview-support
Sep 15, 2023
Merged

chore: add net8.0 preview support#537
stijnmoreels merged 31 commits intoarcus-azure:mainfrom
stijnmoreels:chore/add-net8.0-preview-support

Conversation

@stijnmoreels
Copy link
Copy Markdown
Member

Add .NET 8 (preview) support to the project.

Relates to arcus-azure/arcus#311

@stijnmoreels stijnmoreels added this to the v2.9.0 milestone Aug 17, 2023
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 17, 2023

Deploy Preview for arcus-observability canceled.

Name Link
🔨 Latest commit 4348db1
🔍 Latest deploy log https://app.netlify.com/sites/arcus-observability/deploys/6503d78594da830007b4bb0e

@stijnmoreels
Copy link
Copy Markdown
Member Author

Waiting for arcus-azure/azure-devops-templates#57 to include preview .NET SDK's in the build.

@stijnmoreels stijnmoreels changed the title chore: add net8.0 preview support chore: add net8.0 preview support (🚧👷🏗️) Aug 17, 2023
Comment thread src/Arcus.Observability.Tests.Runtimes.AzureFunction/Dockerfile Outdated
@stijnmoreels stijnmoreels mentioned this pull request Aug 18, 2023
2 tasks
@stijnmoreels
Copy link
Copy Markdown
Member Author

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.04% ⚠️

Comparison is base (2ed0469) 86.34% compared to head (4348db1) 85.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   86.34%   85.31%   -1.04%     
==========================================
  Files          76       76              
  Lines        3201     3201              
  Branches      220      220              
==========================================
- Hits         2764     2731      -33     
- Misses        360      394      +34     
+ Partials       77       76       -1     
Files Changed Coverage Δ
...ons/Extensions/ILoggerHttpRequestDataExtensions.cs 0.00% <ø> (-100.00%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stijnmoreels stijnmoreels changed the title chore: add net8.0 preview support (🚧👷🏗️) chore: add net8.0 preview support Sep 8, 2023
Copy link
Copy Markdown
Member

@fgheysels fgheysels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, you succeeded in getting the dockerstuff working \o/

Comment thread src/Arcus.Observability.Tests.Runtimes.AzureFunction/Dockerfile Outdated
@fgheysels
Copy link
Copy Markdown
Member

There are some hints / advise that the code-analysis is reporting regarding the usage of obsolete methods. MIght be good to tackle that as well ?

@stijnmoreels
Copy link
Copy Markdown
Member Author

There are some hints / advise that the code-analysis is reporting regarding the usage of obsolete methods. MIght be good to tackle that as well ?

Think we currently report the code coverage and any security risks. Obsolete functionality should indeed be part of that security risk assessment. But: we have enabled 'warnings as errors' so those should also break the build.

@stijnmoreels stijnmoreels merged commit 4eea11a into arcus-azure:main Sep 15, 2023
@stijnmoreels stijnmoreels deleted the chore/add-net8.0-preview-support branch September 15, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants