-
-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow using merge directive without keyArg argument if resolver takes 0 arguments #4337
base: master
Are you sure you want to change the base?
allow using merge directive without keyArg argument if resolver takes 0 arguments #4337
Conversation
🦋 Changeset detectedLatest commit: 6b91b09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/theguild/graphql-tools/BNni3KjdepM6quL96r8baCU7xj7U [Deployment for 6b91b09 failed] |
The failed test is unrelated, please rerun it |
But does merging work? Do we have a test elsewhere? I think it does and we do, but offhand I am not sure where. |
Hi, @yaacovCR , I did a manual test and it works. I didn't find the test so I added it, please check it |
@yaacovCR well, now I can confirm that merging doesn't work well if querying not all the fields from the type. I've updated the test case to fail. |
4946aeb
to
4be9073
Compare
d34fb65
to
b8bf584
Compare
Description
Allows using
@merge
directive withoutkeyArg
argument if resolver takes 0 argumentsRelated #4336
Type of change
Checklist: