Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow using merge directive without keyArg argument if resolver takes 0 arguments #4337

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dimatillck
Copy link

Description

Allows using @merge directive without keyArg argument if resolver takes 0 arguments
Related #4336

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2022

🦋 Changeset detected

Latest commit: 6b91b09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-tools/stitching-directives Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/graphql-tools/BNni3KjdepM6quL96r8baCU7xj7U
✅ Preview: Failed

[Deployment for 6b91b09 failed]

@dimatillck
Copy link
Author

The failed test is unrelated, please rerun it

@ardatan ardatan requested a review from yaacovCR March 27, 2022 00:47
@yaacovCR
Copy link
Collaborator

But does merging work? Do we have a test elsewhere? I think it does and we do, but offhand I am not sure where.

@dimatillck
Copy link
Author

Hi, @yaacovCR , I did a manual test and it works. I didn't find the test so I added it, please check it

@dimatillck
Copy link
Author

@yaacovCR well, now I can confirm that merging doesn't work well if querying not all the fields from the type. I've updated the test case to fail.

@ardatan ardatan force-pushed the master branch 2 times, most recently from 4946aeb to 4be9073 Compare July 20, 2022 20:01
@theguild-bot theguild-bot mentioned this pull request Apr 23, 2023
@theguild-bot theguild-bot mentioned this pull request Oct 26, 2023
@theguild-bot theguild-bot mentioned this pull request May 23, 2024
@ardatan ardatan force-pushed the master branch 5 times, most recently from d34fb65 to b8bf584 Compare August 11, 2024 23:45
@ardatan ardatan closed this Dec 24, 2024
@ardatan ardatan reopened this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants