-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added trusted anchors creatting script #94
base: master
Are you sure you want to change the base?
Conversation
|
Memory usage change @ 135cc88
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that certificate updates should not be accepted via pull request, but rather via github actions, an automation that periodically creates PRs with new certificates, so we have the provenance of where the trusted origin is.
I think in this case, the authors can simply accept my commit, including deleting BearSSLTrustAnchors.h if they want, and regenerating it with: sh create_trustAnchors.sh , since it regenerates all the certificates (and can be automated with githb actions) |
I was using src/BearSSLTrustAnchors.h as example for my Single Unity Bearssl https://github.com/OUIsolutions/BearSslSingle-Unit , but I think the certification its expired,you can check the usage in https://github.com/OUIsolutions/BearSslSingle-Unit/tree/main/micro_client.
So I needed to make a way of autmatize these process, for these ,jus run:
sh create_trustAnchors.sh
and it will create the src/BearSSLTrustAnchors.h based on https://curl.se/docs/caextract.html file , located at https://curl.se/ca/cacert.pem