Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial plotter remote commands #7461

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

chromhelm
Copy link
Contributor

This adds remote command to set the size and clear the plot area.
The commands are send like this:
#CLEAR
#SIZE:
size should be between 10 and 5000. This are hard coded limits for the plot size right now.

@facchinm facchinm added the SerialPlotter Tools > Serial Plotter label Sep 20, 2019
@madsdyd
Copy link

madsdyd commented Apr 7, 2020

Is there a consensus about adding "remote commands" (this patch include them)", vs. e.g. the ability to be able to ignore some lines? Traditionally, "#" is often used to indicate a comment in text based data files. An initial suggestion could be to expand the SerialPlotter protocol to

  • Ignore any line starting with "#"
  • Interprent any line starting with "$" as a command to the serial plotter.

The reason for "$" being that it is often used indicate a command prompt.

@madsdyd
Copy link

madsdyd commented Apr 7, 2020

Status of the QA check is that it fails because

  • The method setNewBufferCapacity assigns to one of its parameters.
  • Line 326 needs to be changed from if (commands.equals("CLEAR")) { to if ("CLEAR".equals(commands)) {

Both are trivial to fix

Wilhelm Wiens and others added 4 commits April 9, 2020 14:22
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ chromhelm
❌ Wilhelm Wiens


Wilhelm Wiens seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@stefan123t
Copy link

Thanks for adding the Serial Plotter with Labels and Commands to the Arduino IDE!

Regarding remote commands and comments as described in this PR:

Is there a consensus about adding "remote commands" (this patch include them)", vs. e.g. the ability to be able to ignore some lines? Traditionally, "#" is often used to indicate a comment in text based data files. An initial suggestion could be to expand the SerialPlotter protocol to

* Ignore any line starting with "#"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SerialPlotter Tools > Serial Plotter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants