-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customization of transmit and receive buffer sizes for I2C 'Wire' object. #589
Open
dac1e
wants to merge
7
commits into
arduino:master
Choose a base branch
from
dac1e:dac1e-devel2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SET_Wire_Buffers().
Placed TWI states in enum TWI_STATE : uint8_t.
Memory usage change @ b9df583
Click for full report table
Click for full report CSV
|
Memory usage change @ 4962837
Click for full report table
Click for full report CSV
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I had the need for a bigger 'Wire' buffer, I came up with this implementation.
Existing sketches work like before, but just with one additional macro in the sketch, 'Wire' will have smaller or larger buffers, and will omit unnecessary buffers. E.g. if the sketch is operating only as a master, slave buffers will be omitted. There are four new example sketches available, that demonstrate how the macro works and give evidence about the customization of the buffer sizes.
Wire buffers are still allocated at compile time.
There is also some refactoring done in regard to using C++ casts instead of C casts and making some functions inline for speed and code size.
There is corresponding pull request for the SAM architecture to allow larger or smaller buffers, but with different implementation of what buffers can be omitted in which case.
Pullrequest #149 of ArduinoCore-sam corresponds to this pull request.