Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Serial flush() returning before transmission has completed #328

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix for Serial flush() returning before transmission has completed #328

wants to merge 4 commits into from

Commits on May 28, 2024

  1. Update Serial.h 

    Renamed tx_done to tx_empty
Created tx_complete
    @Hsubtnarg
    Hsubtnarg committed May 28, 2024
    Configuration menu
    Copy the full SHA
    c77faa4 View commit details
    Browse the repository at this point in the history

  2. Update Serial.cpp 

    Separated call back events UART_EVENT_TX_COMPLETE and UART_EVENT_TX_DATA_EMPTY and used UART_EVEN_TX_COMPLETE to determine when flush() should return
    @Hsubtnarg
    Hsubtnarg committed May 28, 2024
    Configuration menu
    Copy the full SHA
    96a369f View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Update Serial.cpp 

    Removed old comment
    @Hsubtnarg
    Hsubtnarg committed May 29, 2024
    Configuration menu
    Copy the full SHA
    f35ad4e View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Update Serial.cpp 

    Added a timeout to flush() because BLE.begin() on the Uno R4 Wifi, would hang without it.
    @Hsubtnarg
    Hsubtnarg committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    d54ce05 View commit details
    Browse the repository at this point in the history