Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump editorconfig-checker/action-editorconfig-checker from 1.0.0 to 2.0.0 #29

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 25, 2023

Bumps editorconfig-checker/action-editorconfig-checker from 1.0.0 to 2.0.0.

Release notes

Sourced from editorconfig-checker/action-editorconfig-checker's releases.

v2.0.0

What's Changed

New Contributors

Full Changelog: editorconfig-checker/action-editorconfig-checker@v1...v2.0.0

v2

No release notes provided.

Commits
  • 0ab3427 Merge pull request #19 from editorconfig-checker/bump-actions-core
  • 2bb6041 chore: update actions core
  • eb99d65 Merge pull request #18 from editorconfig-checker/dependabot/npm_and_yarn/acti...
  • 302d3a8 transpile
  • 901c6a1 Bump @​actions/tool-cache from 1.7.1 to 2.0.1
  • a472c36 Merge pull request #17 from editorconfig-checker/dependabot/npm_and_yarn/type...
  • 8acde40 Bump typescript from 4.5.5 to 5.2.2
  • 8078423 Merge pull request #16 from editorconfig-checker/dependabot/npm_and_yarn/acti...
  • ec61d9e transpile
  • 5a58fb6 Bump @​actions/github from 5.0.0 to 5.1.1
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [editorconfig-checker/action-editorconfig-checker](https://github.com/editorconfig-checker/action-editorconfig-checker) from 1.0.0 to 2.0.0.
- [Release notes](https://github.com/editorconfig-checker/action-editorconfig-checker/releases)
- [Commits](editorconfig-checker/action-editorconfig-checker@v1.0.0...v2.0.0)

---
updated-dependencies:
- dependency-name: editorconfig-checker/action-editorconfig-checker
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the topic: infrastructure Related to project infrastructure label Sep 25, 2023
@per1234 per1234 self-assigned this Sep 25, 2023
@per1234 per1234 added the type: enhancement Proposed improvement label Sep 25, 2023
The editorconfig-checker/action-editorconfig-checker action is used in the "Check General Formatting" GitHub Actions
workflow.

The behavior of that action changed starting from the 2.0.0 release. Previously it ran editorconfig-checker on the files
in the workspace. The action now solely serves to make editorconfig-checker available in the runner machine for use in
subsequent steps of the job (equivalent to the various popular "setup-*" actions for other frameworks/languages/tools).

This means it is now necessary to add a new step to the workflow to actually invoke editorconfig-checker.
…ecker` action

The editorconfig-checker/action-editorconfig-checker action is used in the "Check General Formatting" GitHub Actions
workflow as a convenient way to install the editorconfig-checker tool.

A major version ref is provided by the maintainers of that repository. It will always point to the latest release of the
2.x major version series.

Use of the major version ref will cause the workflow to use a stable version of the action, while also benefiting from
ongoing development to the action up until such time as a new major release of an action is made. At that time we would
need to evaluate whether any changes to the workflow are required by the breaking change that triggered the major
release before manually updating the major ref (e.g., `uses: editorconfig-checker/action-editorconfig-checker@v2` ->
`uses: editorconfig-checker/action-editorconfig-checker@v3`). I think this major version ref approach to action
dependency management strikes the right balance between stability and maintainability for this type of workflow.
@per1234 per1234 merged commit 0950346 into main Sep 25, 2023
13 checks passed
@per1234 per1234 deleted the dependabot/github_actions/editorconfig-checker/action-editorconfig-checker-2.0.0 branch September 25, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant