Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add music on town #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add music on town #7

wants to merge 1 commit into from

Conversation

SohKey
Copy link
Member

@SohKey SohKey commented Jan 18, 2023

require merging aresrpg/resourcepacks#11

@SohKey SohKey requested a review from Sceat January 18, 2023 19:50
@SohKey
Copy link
Member Author

SohKey commented Jan 18, 2023

linked to: aresrpg/aresrpg#607

@Sceat
Copy link
Member

Sceat commented Jan 19, 2023

This looks good, but teleportation stones like musics should be something plugged on top of a delimited zone. Let's first explore how to delimit a zone and have a zones.json in the world module, then each zone will have an optional music and an optional teleportation portal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants