Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: retrieve user by ID #5044

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

datapumpernickel
Copy link

Description

Retrieving a user by ID works only when passing in an ID of class UUID. This has been updated in the docs, as well as in the function examples and one error message of the users.py functions.

Closes #5011

  • Documentation update

How Has This Been Tested

Not tested yet.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@datapumpernickel datapumpernickel changed the title Documentation update docs: retrieve user by ID Jun 18, 2024
@sdiazlor
Copy link
Contributor

Thanks @datapumpernickel, could you change the branch to main?

@datapumpernickel datapumpernickel changed the base branch from develop to main June 19, 2024 07:49
@davidberenstein1957 davidberenstein1957 changed the base branch from main to develop June 19, 2024 07:53
@davidberenstein1957
Copy link
Member

@datapumpernickel, would you be able to change the code so we can obtain users either by str or UUID?

@datapumpernickel datapumpernickel changed the base branch from develop to main June 19, 2024 07:55
@datapumpernickel datapumpernickel changed the base branch from main to develop June 19, 2024 07:56
@datapumpernickel
Copy link
Author

datapumpernickel commented Jun 19, 2024

Woopsie, I was trying to change this to the main branch and did not see your reply @davidberenstein1957 in the meantime. Sorry about the mess.
I could look at it, probably not this week, as I will be off until Mid-July. But then I can give it a try!

@davidberenstein1957
Copy link
Member

davidberenstein1957 commented Jun 19, 2024

Hi @datapumpernickel, no problem. Your contribution is great. I think it might be nicer for users to be able to pass either an id or UUID. @frascuchon @burtenshaw WDYT? Either way, Enjoy the holidays :)

@datapumpernickel
Copy link
Author

Definitely more convenient to be able to pass both -thanks for the hint. It actually seemed pretty straight forward, to I just put in a commit with a small change that checks if the ID is of instance uuid.UUID, if not, it tries to convert it to an instance of uuid.UUID. It returns an error if that fails for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] pulling user by ID does not work as specified in the docs
3 participants