Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected AzureOpenAILLM path to mock the internal class #1115

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Corrected AzureOpenAILLM path to mock the internal class #1115

wants to merge 2 commits into from
+2 −1

Conversation

dameikle
Copy link
Contributor

Updated the internal path for mocking the _prepare_structured_output call in the load method

davidberenstein1957
davidberenstein1957 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dameikle. thanks for this PR.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 4, 2025

CodSpeed Performance Report

Merging #1115 will improve performances by ×4.1

Comparing dameikle:fix_azure (f671940) with develop (f5ddbc6)

Summary

⚡ 1 improvements

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_cache_time 2,171.1 ms 523.5 ms ×4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberenstein1957 davidberenstein1957 davidberenstein1957 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dameikle @davidberenstein1957