Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ensure setup_logging does not modify the root logger #1127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

My-laniaKeA
Copy link

Issue
Attempting to log after executing pipeline.run() may result in an error. This issue arises due to setup_logging(), which modifies the root logger using getLogger(), potentially causing unintended side effects.

Proposed fix
Modify setup_logging() to ensure it configures a dedicated logger for the pipeline.

Copy link

codspeed-hq bot commented Mar 7, 2025

CodSpeed Performance Report

Merging #1127 will degrade performances by 54.02%

Comparing My-laniaKeA:fix-root-logger (d3390d0) with main (1b6c101)

Summary

❌ 1 regressions

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cache_time 553.9 ms 1,204.7 ms -54.02%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant