MLX text decoder #161
Merged
MLX text decoder #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZachNagengast
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Test are passing, awesome! I'll merge this and we can finalize the main PR now. Amazing effort with his project @jkrukowski
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
MLXTextDecoderand relevantMLXlayers implementationsMLXTextDecodertestsTested with https://huggingface.co/jkrukowski/whisper-base-mlx-safetensors and https://huggingface.co/jkrukowski/whisper-tiny-mlx-safetensors models.
Tested different pipelines with combinations of
MLXandCoredecoder / encoder.Possible improvements:
decodeTextmethod, it's a bit messy and copy pasted fromTextEncoderMLXTextDecoder