Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Progress to WhisperKit #71

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Add Progress to WhisperKit #71

merged 1 commit into from
Mar 14, 2024

Conversation

finnvoor
Copy link
Contributor

Currently there doesn't seem to be a way to get the current transcription progress to display. This adds a Progress to WhisperKit for easily displaying transcription progress in a ProgressView as seen in the modified WhisperAX.

The progress could probably be much more fine grained by updating in the decoder loop (and possibly factoring in model load time/anything else?), but this is a pretty good start I think.

@ZachNagengast
Copy link
Contributor

This is cool, good idea! Although it looks a bit strange in streaming mode because the full audio length increases with every loop, can we just disable it for the streaming tab?

@finnvoor
Copy link
Contributor Author

This is cool, good idea! Although it looks a bit strange in streaming mode because the full audio length increases with every loop, can we just disable it for the streaming tab?

Didn't notice that, should be fixed now ✅

@ZachNagengast ZachNagengast merged commit 0b78c52 into argmaxinc:main Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants