Skip to content

Commit

Permalink
Update upstream Rollouts update script PR message
Browse files Browse the repository at this point in the history
Signed-off-by: Jonathan West <[email protected]>
  • Loading branch information
jgwest committed Oct 23, 2024
1 parent 4bb8010 commit 85db81b
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions hack/upgrade-rollouts-script/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,10 @@ func main() {

bodyText += `
Before merging this PR, ensure you check the Argo Rollouts change logs and release notes:
- ensure there are no changes to the Argo Rollouts install YAML that we need to respond to with changes in the operator
- ensure there are no backwards incompatible API/behaviour changes in the change logs`
- Ensure there are no changes to the Argo Rollouts install YAML that we need to respond to with changes in the operator
- You can do this by downloading the 'install.yaml' from both the previous version (for example, v1.7.1) and new version (for example, v1.7.2), and then comparing them using a tool like [Meld](https://gitlab.gnome.org/GNOME/meld) or diff.
- If there are changes to resources like Deployments and Roles in the install.yaml between the two versions, this will likely require a corresponding code change within the operator. e.g. a new permission added to a Role would require a change to the Role creation code in the operator.
- Ensure there are no backwards incompatible API/behaviour changes in the change logs`

// 4) Create PR if it doesn't exist
if stdout, stderr, err := runCommandWithWorkDir(pathToGitHubRepo, "gh", "pr", "create",
Expand Down

0 comments on commit 85db81b

Please sign in to comment.