Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new (Ginkgo-based) E2E tests to verify existing functionality #26

Closed
jgwest opened this issue Jan 24, 2024 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@jgwest
Copy link
Member

jgwest commented Jan 24, 2024

I've contributed initial E2E test fixtures, and E2E tests, as part of #19.

However, all I did was port the existing kuttl tests to Ginkgo.

As part of this current PR, we should add additional E2E tests that more thoroughly test the functionality that is already implemented in this repository.

NOTE: As of this writing, we only support Namespace-scoped Argo Rollouts installs. Thus the tests only need to verify that rollouts can be installed into a single Namespace.

My initial brainstorm was that we should at least do this as part of our E2E tests:

  1. verify that the expected resources are expected
  • service
  • deployment
  • etc
    (I think this is done, but double check)
  1. verify that creation of rollouts manager with args, env vars, work as expected

The Rollouts CR also supports env, extraCommand args, custom image, version. We should make sure these are set as expected.

apiVersion: argoproj.io/v1alpha1
kind: RolloutManager
metadata:
  name: argo-rollout
  labels:
    example: with-properties
spec:
  env:
   - name: "foo"
      value: "bar"
  extraCommandArgs:
   - --foo
   - bar
  image: "quay.io/random/my-rollout-image"
  version: "sha256:...."
  1. Verify that modification of args, env vars, etc, works as expected

The ev, extraCommand args, custom image, version can all be modified. We should ensure that when they are modified on an existing RollutManager, that the change is made correctly to the resources.

  1. Verify that deletion of rolloutsmanager deletes any old resources

Likewise, verify that when a RolloutsManager is deleted that all the expected resources are deleted.

  1. Anything else you can think of?

Issue Criteria:

  • E2E tests implemented as above
  • All E2E tests are Ginkgo-based. We should follow the same fixture-based pattern for these tests that we used in managed-gitops repo. (I've already started following this pattern in the repo).
@jgwest jgwest added the enhancement New feature or request label Jan 24, 2024
@jgwest
Copy link
Member Author

jgwest commented Jan 24, 2024

Red Hat JIRA Tracker: https://issues.redhat.com/browse/GITOPS-3912

@jopit jopit mentioned this issue Feb 2, 2024
@jgwest jgwest closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant