You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've contributed initial E2E test fixtures, and E2E tests, as part of #19.
However, all I did was port the existing kuttl tests to Ginkgo.
As part of this current PR, we should add additional E2E tests that more thoroughly test the functionality that is already implemented in this repository.
NOTE: As of this writing, we only support Namespace-scoped Argo Rollouts installs. Thus the tests only need to verify that rollouts can be installed into a single Namespace.
My initial brainstorm was that we should at least do this as part of our E2E tests:
verify that the expected resources are expected
service
deployment
etc
(I think this is done, but double check)
verify that creation of rollouts manager with args, env vars, work as expected
The Rollouts CR also supports env, extraCommand args, custom image, version. We should make sure these are set as expected.
Verify that modification of args, env vars, etc, works as expected
The ev, extraCommand args, custom image, version can all be modified. We should ensure that when they are modified on an existing RollutManager, that the change is made correctly to the resources.
Verify that deletion of rolloutsmanager deletes any old resources
Likewise, verify that when a RolloutsManager is deleted that all the expected resources are deleted.
Anything else you can think of?
Issue Criteria:
E2E tests implemented as above
All E2E tests are Ginkgo-based. We should follow the same fixture-based pattern for these tests that we used in managed-gitops repo. (I've already started following this pattern in the repo).
The text was updated successfully, but these errors were encountered:
I've contributed initial E2E test fixtures, and E2E tests, as part of #19.
However, all I did was port the existing kuttl tests to Ginkgo.
As part of this current PR, we should add additional E2E tests that more thoroughly test the functionality that is already implemented in this repository.
NOTE: As of this writing, we only support Namespace-scoped Argo Rollouts installs. Thus the tests only need to verify that rollouts can be installed into a single Namespace.
My initial brainstorm was that we should at least do this as part of our E2E tests:
(I think this is done, but double check)
The Rollouts CR also supports env, extraCommand args, custom image, version. We should make sure these are set as expected.
The ev, extraCommand args, custom image, version can all be modified. We should ensure that when they are modified on an existing RollutManager, that the change is made correctly to the resources.
Likewise, verify that when a RolloutsManager is deleted that all the expected resources are deleted.
Issue Criteria:
The text was updated successfully, but these errors were encountered: