Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new e2e tests #36

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Add new e2e tests #36

merged 2 commits into from
Feb 13, 2024

Conversation

jopit
Copy link
Collaborator

@jopit jopit commented Feb 2, 2024

What does this PR do / why we need it:

  • Updates EnsureCleanSlate to delete the Rollouts cluster roles
  • Updates the existing e2e tests
  • Adds new e2e tests
  • Fixes a bug in the operator where the wrong label was set on two of the three aggregate cluster roles

Fixes issue #26

@jgwest jgwest self-requested a review February 12, 2024 20:24
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jopit!

})
})
})
})

func ensureLabels(object *metav1.ObjectMeta) {
GinkgoHelper()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jgwest jgwest merged commit ad19e95 into argoproj-labs:main Feb 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants