Add metric and traffic plugins in Argo Rollouts #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rizwana777
force-pushed
the
issue-4217
branch
3 times, most recently
from
138b5e3
to
0d829de
Compare
Rizwana777
force-pushed
the
issue-4217
branch
from
0d829de
to
74e767e
Compare
jparsai
reviewed
Sep 24, 2024
Signed-off-by: Rizwana777 <[email protected]>
Rizwana777
force-pushed
the
issue-4217
branch
from
74e767e
to
c24d9ec
Compare
|
/lgtm |
jgwest
requested changes
Sep 30, 2024
Rizwana777
force-pushed
the
issue-4217
branch
2 times, most recently
from
1ff9dcb
to
c5dc239
Compare
jgwest
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Looks great, thanks @Rizwana777!
One more request, would you be able to add an example of this feature to this file: https://github.com/argoproj-labs/argo-rollouts-manager/blob/main/docs/crd_reference.md
We've been doing this for the other features we've added, as well.
I also added a few minor nits I noticed while reviewing, then good to go.
Signed-off-by: Rizwana777 <[email protected]>
|
Addressed all the comments @jgwest PTAL |
Signed-off-by: Jonathan West <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - https://issues.redhat.com/browse/GITOPS-4217
Fixes #45