Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HA support for Argo Rollouts #93

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Add HA support for Argo Rollouts #93

merged 5 commits into from
Oct 23, 2024

Conversation

Rizwana777
Copy link
Collaborator

Fixes #92

@Rizwana777 Rizwana777 force-pushed the issue-5622 branch 19 times, most recently from 41b3ba8 to 34d81d9 Compare October 1, 2024 12:30
jgwest
jgwest requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Rizwana777.

In addition to requested changes, a couple minor items:

  • Needs a rebase after some PRs that went in recently
  • Can you add an example of HA to docs/crd_reference.md. This is what we have been doing for other features.

api/v1alpha1/argorollouts_types.go Show resolved Hide resolved
controllers/deployment.go Show resolved Hide resolved
controllers/deployment.go Show resolved Hide resolved
api/v1alpha1/argorollouts_types.go Outdated Show resolved Hide resolved
controllers/deployment.go Show resolved Hide resolved
controllers/deployment_test.go Show resolved Hide resolved
tests/e2e/rollout_tests_all.go Outdated Show resolved Hide resolved
tests/e2e/rollout_tests_all.go Show resolved Hide resolved
controllers/deployment.go Outdated Show resolved Hide resolved
@Rizwana777 Rizwana777 force-pushed the issue-5622 branch 4 times, most recently from e2e87b4 to cc1db44 Compare October 22, 2024 12:09
@Rizwana777
Fix conflicts
139909b 
Signed-off-by: Rizwana777 <[email protected]>
@Rizwana777
Minor fixes
82ad855 
Signed-off-by: Rizwana777 <[email protected]>
jgwest
jgwest approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Rizwana777!

@jgwest jgwest merged commit fb79499 into argoproj-labs:main Oct 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgwest jgwest jgwest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for HA in Rollouts operator
2 participants
@Rizwana777 @jgwest