Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use goreman to start principal and agent #187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jparsai
Copy link
Contributor

@jparsai jparsai commented Sep 24, 2024

This PR is to make use of goreman to run principal and agent in same console, this would make debugging easy as logs of both components would be printed in same console, also it would help to understand the order of execution of agent and principal code blocks.

Copy link
Collaborator

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I do like this idea.

However, I think neither goreman nor make configuration should be part of the top-level for now.

My suggestion would be to place the Procfile into (a new) hack/demo-env/Procfile and Makefile (if required at all) into hack/demo-env/Makefile instead.

Copy link
Collaborator

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think that there really should be two agent targets in Procfile, agent-managed and agent-autonomous. Or some logic that lets you start one or the other.

@jparsai
Copy link
Contributor Author

jparsai commented Oct 4, 2024

Thanks for looking into this. I moved Procfile inside hack/demo-env/ directory, but moving Makefile requires changes in start up scripts, because they have to be executed from root folder. I was not sure if I should modify start up scripts for this.
To set agent mode I introduced an env variable AUTONOMOUS_MODE, which can be used like this

AUTONOMOUS_MODE=true make start-local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants