chore(scripts): Fix OpenShift detection in setup-vcluster-env.sh #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test to detect OpenShift in the
setup-vcluster-env.sh
scriptis not working.
grep -q
will return success as soon as it detects the first match. This will close the pipe between thekubectl
command and thegrep
command. Thekubectl
command will then try to write its next result to the closed pipe, causing it to error out. Since the script has setset -o pipefail
, the entire pipeline will then error out, resulting in theOPENSHIFT
variable not being set.This PR fixes this by forcing the
kubectl
step to always exit successfully.