Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: demo/dev guide - add running argocd agent components in clusters using open cluster management #208

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

mikeshng
Copy link
Contributor

Enhance the demo/dev guide docs with steps to run the agent components using Open Cluster Management and it's addon framework.

Copy link
Collaborator

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just have a minor comment, PTAL below

Comment on lines 16 to 17
automated:
prune: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For demo purposes, I think this should stay on manual.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed as suggested. Thanks.

Comment on lines 16 to 17
automated:
prune: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For demo purposes, I think this should stay on manual.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed as suggested. Thanks.

…s using open cluster management

Signed-off-by: Mike Ng <[email protected]>
Copy link
Collaborator

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Freaking awesome ❤️

LGTM.

@jannfis jannfis merged commit 701d19a into argoproj-labs:main Oct 25, 2024
11 checks passed
@mikeshng mikeshng deleted the ocm-addon-dev branch October 25, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants