feat: Add informer metrics #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 46.99% 47.01% +0.02%
==========================================
Files 57 57
Lines 4886 4956 +70
==========================================
+ Hits 2296 2330 +34
- Misses 2413 2444 +31
- Partials 177 182 +5 ☔ View full report in Codecov by Sentry. |
jannfis
force-pushed
the
feat/informer-metrics
branch
2 times, most recently
from
913d7e8
to
2fbc2de
Compare
Signed-off-by: jannfis <[email protected]>
jannfis
force-pushed
the
feat/informer-metrics
branch
from
2fbc2de
to
0bcda12
Compare
jannfis
commented
Oct 30, 2024
Comment on lines
-86
to
-90
| - name: Restore go build cache | ||
| uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # v4.0.0 | ||
| with: | ||
| path: ~/.cache/go-build | ||
| key: ${{ runner.os }}-go-build-v1-${{ github.run_id }} |
There was a problem hiding this comment.
Cache was not used anyway.
jannfis
commented
Oct 30, 2024
Comment on lines
-107
to
-111
| - name: Restore go build cache | ||
| uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # v4.0.0 | ||
| with: | ||
| path: ~/.cache/go-build | ||
| key: ${{ runner.os }}-go-build-v1-${{ github.run_id }} |
There was a problem hiding this comment.
Cache was not used anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds metrics to the generic informer, conveniently handled within the callbacks.
Additionally, it adds some unit tests for the informer package.
The next step will move the existing application informer to use the generic informer, too.