chore(scripts): fix argocd deploy release version

[mikeshng]

For the demo/dev env script, the ArgoCD deployments installed on the hub and spoke are using the latest tag instead of the release tag. This is due to the kustomization yamls are all using ?ref=stable but the argocd github repo still references latest (bug with argocd repo?). For example, https://github.com/argoproj/argo-cd/blob/stable/manifests/base/server/argocd-server-deployment.yaml#L21

This fix is to replace the latest tag with the latest stable release tag.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.89%. Comparing base (46b9eea) to head (685f3fd).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   46.89%   46.89%           
=======================================
  Files          57       57           
  Lines        4956     4956           
=======================================
  Hits         2324     2324           
  Misses       2451     2451           
  Partials      181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jannfis]

Good catch.

However, wouldn't that trigger a diff in Git once you run the setup?

[mikeshng]

All the files are copied to a tmp folder first before the sed modifications so it should be ok. A few lines above:

apply() {
	TMP_DIR=`mktemp -d`
	echo "-> TMP_DIR is $TMP_DIR"
	cp -r ${SCRIPTPATH}/* $TMP_DIR

[jannfis]

You're absolutely right!

LGTM.