Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve namespace handling in AppInformer #215

Closed
wants to merge 1 commit into from

Conversation

jannfis
Copy link
Collaborator

@jannfis jannfis commented Nov 4, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 35 lines in your changes missing coverage. Please review.

Project coverage is 46.75%. Comparing base (46b9eea) to head (50664ad).

Files with missing lines Patch % Lines
principal/options.go 0.00% 12 Missing ⚠️
cmd/principal/main.go 0.00% 10 Missing ⚠️
principal/server.go 69.23% 8 Missing ⚠️
internal/informer/application/options.go 40.00% 3 Missing ⚠️
internal/informer/application/appinformer.go 87.50% 1 Missing ⚠️
internal/informer/appproject/projectinformer.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   46.89%   46.75%   -0.15%     
==========================================
  Files          57       57              
  Lines        4956     4986      +30     
==========================================
+ Hits         2324     2331       +7     
- Misses       2451     2474      +23     
  Partials      181      181              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannfis
Copy link
Collaborator Author

jannfis commented Nov 5, 2024

Will be replaced by a major overhaul of the AppInformer

@jannfis jannfis closed this Nov 5, 2024
@jannfis jannfis deleted the refactor/app-informer branch November 8, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants