Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AppProject informer should be single namespace #216

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

jannfis
Copy link
Collaborator

@jannfis jannfis commented Nov 5, 2024

The AppProject informer should not be cluster-scoped and instead operate in a single namespace.

Fixes #213

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.83%. Comparing base (237faa7) to head (dc8d78d).

Files with missing lines Patch % Lines
internal/informer/appproject/projectinformer.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   46.89%   46.83%   -0.06%     
==========================================
  Files          57       57              
  Lines        4956     4951       -5     
==========================================
- Hits         2324     2319       -5     
  Misses       2451     2451              
  Partials      181      181              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ishitasequeira ishitasequeira merged commit 97e0bdd into main Nov 5, 2024
11 checks passed
@ishitasequeira ishitasequeira deleted the fix/appproject-scope branch November 5, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppProject informer shouldn't be cluster scoped when namespace is not set
4 participants