Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: AppInformer now uses GenericInformer as foundation #221

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jannfis
Copy link
Collaborator

@jannfis jannfis commented Nov 8, 2024

This refactor makes the AppInformer use GenericInformer instead of rolling its own.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 65.00000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 46.91%. Comparing base (97e0bdd) to head (5bdcbb5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/informer/application/appinformer.go 64.83% 24 Missing and 8 partials ⚠️
agent/agent.go 40.00% 2 Missing and 1 partial ⚠️
internal/informer/application/options.go 76.92% 3 Missing ⚠️
principal/server.go 25.00% 2 Missing and 1 partial ⚠️
...ernal/backend/kubernetes/application/kubernetes.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   46.83%   46.91%   +0.07%     
==========================================
  Files          57       57              
  Lines        4951     4896      -55     
==========================================
- Hits         2319     2297      -22     
+ Misses       2451     2420      -31     
+ Partials      181      179       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants