Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support app deletion for autonomous mode #89

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

jannfis
Copy link
Collaborator

@jannfis jannfis commented Jun 20, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 52.47525% with 48 lines in your changes missing coverage. Please review.

Project coverage is 48.85%. Comparing base (97b765b) to head (7a410e6).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/manager/application/application.go 70.17% 12 Missing and 5 partials ⚠️
principal/callbacks.go 0.00% 11 Missing ⚠️
principal/event.go 28.57% 10 Missing ⚠️
pkg/types/types.go 0.00% 4 Missing ⚠️
agent/outbound.go 0.00% 3 Missing ⚠️
internal/event/event.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   46.92%   48.85%   +1.93%     
==========================================
  Files          51       52       +1     
  Lines        3207     3287      +80     
==========================================
+ Hits         1505     1606     +101     
+ Misses       1568     1541      -27     
- Partials      134      140       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannfis jannfis force-pushed the feat/app-deletion branch 2 times, most recently from 91eba62 to 65146f8 Compare June 20, 2024 21:32
@jannfis jannfis marked this pull request as ready for review June 21, 2024 13:04
@jannfis jannfis changed the title feat: Support app deletion properly feat: Support app deletion for autonomous mode Jun 21, 2024
@jannfis jannfis merged commit b29451c into main Jul 3, 2024
10 checks passed
@jannfis jannfis deleted the feat/app-deletion branch July 5, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants