Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update docs to enable the ext #23

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Conversation

ashutosh16
Copy link
Contributor

@ashutosh16 ashutosh16 commented Oct 1, 2024

No description provided.

@ashutosh16 ashutosh16 force-pushed the ui-fix branch 6 times, most recently from c0e347e to 2ac577d Compare October 1, 2024 19:10
leoluz
leoluz previously requested changes Oct 9, 2024
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments

Makefile Outdated Show resolved Hide resolved
ui/package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
@ashutosh16 ashutosh16 marked this pull request as ready for review October 29, 2024 20:42
@ashutosh16 ashutosh16 requested a review from a team as a code owner October 29, 2024 20:42
Signed-off-by: ashutosh16 <[email protected]>
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit 67cd661 into argoproj-labs:main Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants