feat: publish release manifests as github release asset #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
agaudreault
reviewed
Oct 10, 2024
scripts/manifests-release.sh
Outdated
Comment on lines
19
to
20
| IMAGE_NAMESPACE="${IMAGE_NAMESPACE:-quay.io/argoprojlabs}" | ||
| IMAGE_FULLNAME="$IMAGE_NAMESPACE/argocd-ephemeral-access:$IMAGE_TAG" |
There was a problem hiding this comment.
Should we redefine defaults here or trust the makefile to send the correct args?
Makefile already contains
# docker image publishing options
IMAGE_NAMESPACE?=argoproj-labs
IMAGE_NAME=${IMAGE_NAMESPACE}/argocd-ephemeral-access
There was a problem hiding this comment.
@agaudreault I removed the IMAGE_NAMESPACE from the script to avoid conflict. However it was working as expected.
BTW, you can validate the manifest release with: make goreleaser-build-local and inspect the dist/install.yaml file
Signed-off-by: Leonardo Luz Almeida <[email protected]>
agaudreault
approved these changes
Oct 10, 2024
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.