Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add run make target to initialize all components locally #43

Merged
merged 1 commit into from
Oct 17, 2024
Merged

chore: add run make target to initialize all components locally #43

merged 1 commit into from
Oct 17, 2024

Conversation

leoluz
Copy link
Collaborator

@leoluz leoluz commented Oct 17, 2024

No description provided.

@leoluz leoluz requested a review from a team as a code owner October 17, 2024 14:56
crenshaw-dev
crenshaw-dev approved these changes Oct 17, 2024
View reviewed changes
Copy link

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Probably a good time to start adding "how to run locally" docs. I see the default ns is hard-coded in procfile. That's fine, just might need to be documented.

@leoluz leoluz merged commit caa349b into argoproj-labs:main Oct 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agaudreault agaudreault agaudreault approved these changes

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leoluz @crenshaw-dev @agaudreault