Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer for codegen ui #55

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ashutosh16
Copy link
Contributor

No description provided.

Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>

chores(ui): codegen ui

Signed-off-by: ashutosh16 <[email protected]>

chores(ui): codegen ui

Signed-off-by: ashutosh16 <[email protected]>

chores(ui): codegen ui

Signed-off-by: ashutosh16 <[email protected]>

chores(ui): codegen ui

Signed-off-by: ashutosh16 <[email protected]>

chores(ui): codegen ui

Signed-off-by: ashutosh16 <[email protected]>
@ashutosh16 ashutosh16 marked this pull request as ready for review November 6, 2024 20:52
@ashutosh16 ashutosh16 requested a review from a team as a code owner November 6, 2024 20:52
Signed-off-by: ashutosh16 <[email protected]>
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the broken functionality

ui/src/ephemeral-access.tsx Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated
@@ -259,6 +259,15 @@ generate-mocks: mockery ## Generate the mocks for the project as configured in .
clean-ui:
find ${UI_DIR} -type f -name extension.tar -delete

PHONY: codegen-download-openapi
codegen-download-openapi: run-backend
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work as it blocks during run-backend and never executes the yarn command below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the missing files; ran in local and able to generate the schema.yaml

Makefile Outdated Show resolved Hide resolved
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants