Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement AppProject role management #8

Merged
merged 11 commits into from
Aug 6, 2024
Merged

feat: Implement AppProject role management #8

merged 11 commits into from
Aug 6, 2024

Conversation

leoluz
Copy link
Collaborator

@leoluz leoluz commented Aug 1, 2024

No description provided.

@leoluz
feat: implement appproject role management
b2821a5 
Signed-off-by: Leonardo Luz Almeida <[email protected]>
@leoluz
feat: Implement AppProject role management
7dddae5 
Signed-off-by: Leonardo Luz Almeida <[email protected]>
@leoluz
remove unnecessary kubebuilder tag
beee8f3 
Signed-off-by: Leonardo Luz Almeida <[email protected]>
@leoluz
patch appproject with optimistic locking
828fc40 
Signed-off-by: Leonardo Luz Almeida <[email protected]>
@leoluz
add godoc
bbe718e 
Signed-off-by: Leonardo Luz Almeida <[email protected]>
@leoluz
update tests
9746934 
Signed-off-by: Leonardo Luz Almeida <[email protected]>
@leoluz leoluz requested a review from agaudreault August 5, 2024 18:21
@leoluz
add more tests
03f1767 
Signed-off-by: Leonardo Luz Almeida <[email protected]>
@leoluz
minor test tweaks
9263d6a 
Signed-off-by: Leonardo Luz Almeida <[email protected]>
agaudreault
agaudreault requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few concerns over the project reference in the spec and the source of truth when removing access. Other that that, LGTM.

api/argoproj/v1alpha1/appproject.go Show resolved Hide resolved
api/v1alpha1/accessrequest_types.go Outdated Show resolved Hide resolved
internal/controller/accessrequest_controller.go Show resolved Hide resolved
internal/controller/accessrequest_controller.go Outdated Show resolved Hide resolved
internal/controller/accessrequest_controller.go Show resolved Hide resolved
test/manifests/crd/schema/appproject-crd.yaml Show resolved Hide resolved
internal/controller/accessrequest_controller.go Show resolved Hide resolved
@leoluz
address review comments
504b65f 
Signed-off-by: Leonardo Luz Almeida <[email protected]>
@leoluz
Retrieve project from Application
5180035 
Signed-off-by: Leonardo Luz Almeida <[email protected]>
@leoluz
fix CRD
5f06593 
Signed-off-by: Leonardo Luz Almeida <[email protected]>
agaudreault
agaudreault approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit b5c0cd3 into argoproj-labs:main Aug 6, 2024
2 checks passed
@leoluz leoluz deleted the appproject branch August 6, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agaudreault agaudreault agaudreault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoluz @agaudreault