Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vars for extension #10

Merged
merged 3 commits into from
Oct 7, 2024
Merged

feat: add vars for extension #10

merged 3 commits into from
Oct 7, 2024

Conversation

ashutosh16
Copy link
Contributor

@ashutosh16 ashutosh16 commented Oct 1, 2024 •
edited
Loading

Tested the vars

kubectl exec argocd-server-5dc7d48ff4-2dfgz       -- cat   /tmp/extensions/resources/extension-EphemeralAccess.js/extension-6-EphemeralAccess-vars.js
((window) => { const vars = { "ARGOCD_ACCESS_EXT_LABEL_KEY": "application.environmentLabelKey", "ARGOCD_ACCESS_EXT_LABEL_VALUE": "prd" }; window.EphemeralAccess_VARS = vars; })(window);

leoluz
leoluz requested changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments

image/exported_envirnoment_variables.png Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
leoluz
leoluz requested changes Oct 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
@ashutosh16 ashutosh16 marked this pull request as ready for review October 4, 2024 19:02
@ashutosh16 ashutosh16 requested a review from leoluz October 4, 2024 19:02
leoluz
leoluz requested changes Oct 7, 2024
View reviewed changes
README.md Outdated
})(window);
```
Exported envirnoment variables available in the widget:
![imge](./image/exported_envirnoment_variables.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables present in the image don't correspond with the example above which can confuse ppl.
Please update the image with the vars from the example above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the image

@ashutosh16
feat: add vars for extension
8d33db4 
Signed-off-by: ashutosh16 <[email protected]>

feat: add vars for extension

Signed-off-by: ashutosh16 <[email protected]>

feat: add vars for extension

Signed-off-by: ashutosh16 <[email protected]>

feat: ui installer

Signed-off-by: ashutosh16 <[email protected]>

feat: ui installer

Signed-off-by: ashutosh16 <[email protected]>

feat: ui installer

Signed-off-by: ashutosh16 <[email protected]>

feat: ui installer

Signed-off-by: ashutosh16 <[email protected]>

feat: ui installer

Signed-off-by: ashutosh16 <[email protected]>

feat: ephemeral installer

Signed-off-by: ashutosh16 <[email protected]>

feat: ephemeral installer

Signed-off-by: ashutosh16 <[email protected]>

feat: ephemeral installer

Signed-off-by: ashutosh16 <[email protected]>

feat: ephemeral installer

Signed-off-by: ashutosh16 <[email protected]>

feat: ephemeral installer

Signed-off-by: ashutosh16 <[email protected]>
@ashutosh16 ashutosh16 requested a review from leoluz October 7, 2024 17:11
leoluz
leoluz approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit 984db33 into argoproj-labs:main Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashutosh16 @leoluz