Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the installer issue when vars not define #12

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix the installer issue when vars not define #12

merged 2 commits into from
Oct 10, 2024

Conversation

ashutosh16
Copy link
Contributor

Test without vars

  • Should be able to install the extension successfully

Test with vars
export EXTENSION_NAME=xxx
export EXTENSION_JS_VARS=xx

  • Should be able to install the extension with J file successfully

leoluz
leoluz requested changes Oct 10, 2024
View reviewed changes
install.sh Outdated Show resolved Hide resolved
@ashutosh16 ashutosh16 marked this pull request as ready for review October 10, 2024 18:14
@leoluz leoluz merged commit 44a5ab8 into argoproj-labs:main Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashutosh16 @leoluz