-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Multiple Sources as per ArgoCD v2.6.0 New Field #513
Comments
@cregev this is partially due to using an old version of the argo-cd/v2 module. https://github.com/argoproj-labs/argocd-image-updater/blob/master/go.mod#L7 I tried upping it to 2.6.7 for current and that required some other module changes which looks to have broken other code. I'm a nub at Go, otherwise I'd be taking a closer look at this. |
Is this project dead ? I tried duplicating the first element of sources to source (ignored by argocd 2.6+), but argocd-image-updater still does not pick it. |
This project is not dead, just hibernating a little at the moment. The multiple sources feature in Argo CD is in beta-status, and I suppose if you do not use multiple sources in Argo CD, there will be no incompatibility? |
You're right, I didn't see it was a beta feature. |
Is your feature request related to a problem? Please describe.
ArgoCD v2.6.0-rc1 introduced a new field called
sources
, which overrides thesource
field of theapplication
resource. When setting image-updater on such application, we get:level=warning msg="skipping app 'myapp-staging' of type '' because it's not of supported source type" application=myapp-staging
which indicates that image-updater does not recognize this application as of valid source type.
Describe the solution you'd like
Seems like a minor update could make image-updater aware of this new
sources
field and apply some logic accordinglyDescribe alternatives you've considered
Couldn't find any
Additional context
None
The text was updated successfully, but these errors were encountered: