-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multisource + upgrade k8s and argocd pkg + update to go 1.20 (fix #513) #548
base: master
Are you sure you want to change the base?
Conversation
Nice! Can we please decouple the upgrade of Argo CD, update of Go and the functional changes in three separate PRs? |
I can make two PRs :
I still need to add some unit test for that, I'll do it when I can. |
Sounds reasonable, thanks! |
Thank you! we were developing something very similar, let me know if I can help. |
Hey everyone! I've tested this PR in our environment and looks like it is working with multisource, to help this feature be available in a future release of argocd-image-updater I've already created the PR to bump golang release in a new pull request #564 |
I tested the changes briefly, I noticed that it only updates the first element of the array when using multi source :
|
any plan when you will merge and release these feature? |
Signed-off-by: Andre Ferraz <[email protected]>
I tested too. Same behavior as mentioned by @binboum.
|
Hello, any news on this feature ? It would be nice to implement this as we are generalizing the use of multi source app :) |
Hey, any plan when you will merge and release these feature? Thanks ! |
Seems like this PR is likely massively out of date. When will this get merged? I mean, it makes the project basically unusable when using multiple sources. |
Has any movement happened with this? |
Functional, however unit tests for multi-source needs to be updated.
fix: #513