feat: Allow ACR authentication using Azure CLI #609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhy89
force-pushed
the
feat/add-azure-cli
branch
from
011ca07
to
83054a5
Compare
Install azure-cli in Docker image in order to use the `az acr login` command.
Can be used with Azure Managed Identities with the following script:
```yaml
---
apiVersion: v1
kind: ConfigMap
metadata:
name: argocd-image-updater-config
namespace: argocd
data:
log.level: debug
registries.conf: |
registries:
- name: acrexample
api_url: https://acrexample.azurecr.io/
prefix: acrexample.azurecr.io
ping: yes
insecure: no
credentials: ext:/app/scripts/acr-login.sh
credsexpire: 10h
---
apiVersion: v1
kind: ConfigMap
metadata:
name: argocd-image-updater-config-acr
namespace: argocd
data:
acr-login.sh: |
#!/bin/sh
LOGIN=$(az login --identity)
REGISTRY="acrexample"
TOKEN=$(az acr login --name $REGISTRY --expose-token --output tsv --query accessToken)
echo "00000000-0000-0000-0000-000000000000:$TOKEN"
```
Closes argoproj-labs#550 and argoproj-labs#473
Signed-off-by: Jarvis Yang <[email protected]>
Signed-off-by: Jarvis Yang <[email protected]>
Signed-off-by: Jarvis Yang <[email protected]>
Signed-off-by: Jarvis Yang <[email protected]>
Signed-off-by: Jarvis Yang <[email protected]>
Signed-off-by: Daniel Mavis <[email protected]> Signed-off-by: Jarvis Yang <[email protected]>
…ns (argoproj-labs#584) Signed-off-by: Daniel Mavis <[email protected]> Signed-off-by: Jarvis Yang <[email protected]>
Co-authored-by: Abdellah Derfoufi <[email protected]> Signed-off-by: Jarvis Yang <[email protected]>
Signed-off-by: satoru <[email protected]> Signed-off-by: Jarvis Yang <[email protected]>
Signed-off-by: Jarvis Yang <[email protected]>
Signed-off-by: satoru <[email protected]> Signed-off-by: Jarvis Yang <[email protected]>
* ci: Fix codegen Signed-off-by: jannfis <[email protected]> * Fix tar call Signed-off-by: jannfis <[email protected]> --------- Signed-off-by: jannfis <[email protected]> Signed-off-by: Jarvis Yang <[email protected]>
…roj-labs#573) * Fix original override not respected Signed-off-by: KS. Yim <[email protected]> * Add writeOverrides unittest Signed-off-by: KS. Yim <[email protected]> * Add helm override commit test Signed-off-by: KS. Yim <[email protected]> * lint Signed-off-by: KS. Yim <[email protected]> * fix shadowed err Signed-off-by: KS. Yim <[email protected]> --------- Signed-off-by: KS. Yim <[email protected]> Co-authored-by: KS. Yim <[email protected]> Signed-off-by: Jarvis Yang <[email protected]>
…rgoproj-labs#594) * fix: update go mods to use newer argocd app definition Signed-off-by: Jesse Bye <[email protected]> * fix deps and tests Signed-off-by: Jesse Bye <[email protected]> * fix spelling Signed-off-by: Jesse Bye <[email protected]> --------- Signed-off-by: Jesse Bye <[email protected]> Signed-off-by: Jarvis Yang <[email protected]>
…abs#599) Signed-off-by: Viacheslav Sychov <[email protected]> Signed-off-by: Jarvis Yang <[email protected]>
…labs#600) makes argocd-image-updater compatible with restricted Pod Security Standard Signed-off-by: Takeo Sawada <[email protected]> Signed-off-by: Jarvis Yang <[email protected]>
…ion (argoproj-labs#424) * Add possibility to specify write-back GIT repository as annotation. Signed-off-by: flozzone <[email protected]> * Update golangci-lint to 1.52.2. Signed-off-by: flozzone <[email protected]> * Replace deprecated golangci linters with 'unused' linter. Signed-off-by: flozzone <[email protected]> * Fix Goimport issues. Signed-off-by: flozzone <[email protected]> --------- Signed-off-by: flozzone <[email protected]> Signed-off-by: Jarvis Yang <[email protected]>
Signed-off-by: Jarvis Yang <[email protected]>
jwhy89
force-pushed
the
feat/add-azure-cli
branch
from
af52ee5
to
41aef00
Compare
|
@jannfis I don't know where @xesceb went but here's the updated PR with DCO. |
|
Closed by #586 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install azure-cli in Docker image in order to use the az acr login command.
Can be used with Azure Managed Identities with the following script:
The script should contain the name of the registry:
Closes #550 #473 and #586