Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #896 App of apps being overwritten by image-updater #918

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: #896 App of apps being overwritten by image-updater #918

merged 1 commit into from
Nov 8, 2024
+15 −28

Conversation

chengfang
Copy link
Collaborator

Fixes #896

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.64%. Comparing base (e06eb69) to head (4b62385).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
- Coverage   74.70%   74.64%   -0.06%     
==========================================
  Files          31       31              
  Lines        3922     3913       -9     
==========================================
- Hits         2930     2921       -9     
  Misses        856      856              
  Partials      136      136

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chengfang
Copy link
Collaborator Author

the real changes are captured in the screenshot below. findApplicationByName function is deleted and inlined into GetApplication, and the element type of matchedApps is changed from pointer to Application.

Screenshot 2024-11-06 at 8 49 52 AM

fletch3555
fletch3555 approved these changes Nov 8, 2024
View reviewed changes
Copy link

@fletch3555 fletch3555 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix!

jannfis
jannfis approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit 8146cf1 into argoproj-labs:master Nov 8, 2024
10 checks passed
@jannfis
Copy link
Contributor

jannfis commented Nov 8, 2024

We should put out a 0.15.1 with this fix asap.

@chengfang
Copy link
Collaborator Author

chengfang commented Nov 8, 2024 •
edited
Loading

thanks @jannfis . I'll cherry-pick bug fixes to release-0.15 branch and work on the v0.15.1 (#920) https://issues.redhat.com/browse/GITOPS-5813

chengfang added a commit to chengfang/argocd-image-updater that referenced this pull request Nov 8, 2024
@chengfang
fix: argoproj-labs#896 App of apps being overwritten by image-updater (…
589df0f 
…argoproj-labs#918)

Signed-off-by: Cheng Fang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

@fletch3555 fletch3555 fletch3555 approved these changes

@pasha-codefresh pasha-codefresh Awaiting requested review from pasha-codefresh pasha-codefresh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App of apps being overwritten by image-updater
4 participants
@chengfang @codecov-commenter @jannfis @fletch3555