fix: if app has no subscriptions, then nothing to process (#174)

fix: if app has no subscriptions, then nothing to process (#174)

controller/controller.go

@@ -348,7 +348,8 @@ func (c *notificationController) processQueueItem() (processNext bool) {
 		logEntry.Errorf("Failed to process: %v", err)
 		return
 	}
-	if !reflect.DeepEqual(app.GetAnnotations(), appCopy.GetAnnotations()) {
+
+	if !isTheSame(app.GetAnnotations(), appCopy.GetAnnotations()) {
 		annotationsPatch := make(map[string]interface{})
 		for k, v := range appCopy.GetAnnotations() {
 			annotationsPatch[k] = v
@@ -376,3 +377,26 @@ func (c *notificationController) processQueueItem() (processNext bool) {
 
 	return
 }
+
+func isTheSame(appAnnotations, appCopyAnnotations map[string]string) bool {
+	if appAnnotations == nil {
+		if appCopyAnnotations == nil {
+			return true
+		}
+		if len(appCopyAnnotations) == 0 {
+			return true
+		} else {
+			return false
+		}
+	}
+
+	if appCopyAnnotations == nil {
+		if len(appAnnotations) == 0 {
+			return true
+		} else {
+			return false
+		}
+	}
+
+	return reflect.DeepEqual(appAnnotations, appCopyAnnotations)
+}

controller/controller_test.go

@@ -254,3 +254,65 @@ var testsAppSyncStatusRefreshed = map[string]struct {
 		},
 	}, result: false},
 }
+
+func TestAnnotationIsTheSame(t *testing.T) {
+	t.Run("same", func(t *testing.T) {
+		app1 := NewApp("test", WithAnnotations(map[string]string{
+			subscriptions.SubscribeAnnotationKey("my-trigger", "mock"): "recipient",
+		}))
+		app2 := NewApp("test", WithAnnotations(map[string]string{
+			subscriptions.SubscribeAnnotationKey("my-trigger", "mock"): "recipient",
+		}))
+		assert.True(t, isTheSame(app1.GetAnnotations(), app2.GetAnnotations()))
+	})
+
+	t.Run("same-nil-nil", func(t *testing.T) {
+		app1 := NewApp("test", WithAnnotations(nil))
+		app2 := NewApp("test", WithAnnotations(nil))
+		assert.True(t, isTheSame(app1.GetAnnotations(), app2.GetAnnotations()))
+	})
+
+	t.Run("same-nil-emptyMap", func(t *testing.T) {
+		app1 := NewApp("test", WithAnnotations(nil))
+		app2 := NewApp("test", WithAnnotations(map[string]string{}))
+		assert.True(t, isTheSame(app1.GetAnnotations(), app2.GetAnnotations()))
+	})
+
+	t.Run("same-emptyMap-nil", func(t *testing.T) {
+		app1 := NewApp("test", WithAnnotations(map[string]string{}))
+		app2 := NewApp("test", WithAnnotations(nil))
+		assert.True(t, isTheSame(app1.GetAnnotations(), app2.GetAnnotations()))
+	})
+
+	t.Run("same-emptyMap-emptyMap", func(t *testing.T) {
+		app1 := NewApp("test", WithAnnotations(map[string]string{}))
+		app2 := NewApp("test", WithAnnotations(map[string]string{}))
+		assert.True(t, isTheSame(app1.GetAnnotations(), app2.GetAnnotations()))
+	})
+
+	t.Run("notSame-nil-map", func(t *testing.T) {
+		app1 := NewApp("test", WithAnnotations(nil))
+		app2 := NewApp("test", WithAnnotations(map[string]string{
+			subscriptions.SubscribeAnnotationKey("my-trigger", "mock"): "recipient",
+		}))
+		assert.False(t, isTheSame(app1.GetAnnotations(), app2.GetAnnotations()))
+	})
+
+	t.Run("notSame-map-nil", func(t *testing.T) {
+		app1 := NewApp("test", WithAnnotations(map[string]string{
+			subscriptions.SubscribeAnnotationKey("my-trigger", "mock"): "recipient",
+		}))
+		app2 := NewApp("test", WithAnnotations(nil))
+		assert.False(t, isTheSame(app1.GetAnnotations(), app2.GetAnnotations()))
+	})
+
+	t.Run("notSame-map-map", func(t *testing.T) {
+		app1 := NewApp("test", WithAnnotations(map[string]string{
+			subscriptions.SubscribeAnnotationKey("my-trigger", "mock"): "recipient",
+		}))
+		app2 := NewApp("test", WithAnnotations(map[string]string{
+			subscriptions.SubscribeAnnotationKey("my-trigger", "mock"): "recipient2",
+		}))
+		assert.False(t, isTheSame(app1.GetAnnotations(), app2.GetAnnotations()))
+	})
+}