Skip to content

Commit

Permalink
Fix go-lint ci failure
Browse files Browse the repository at this point in the history
Signed-off-by: Siddhesh Ghadi <[email protected]>
  • Loading branch information
svghadi committed Aug 8, 2023
1 parent 0a971d2 commit ffc9633
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
3 changes: 2 additions & 1 deletion api/v1alpha1/argocd_conversion.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ package v1alpha1
import (
"reflect"

v1beta1 "github.com/argoproj-labs/argocd-operator/api/v1beta1"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/conversion"

"github.com/argoproj-labs/argocd-operator/api/v1beta1"
)

var conversionLogger = ctrl.Log.WithName("conversion-webhook")
Expand Down
5 changes: 0 additions & 5 deletions config/webhook/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,5 @@ resources:
#- manifests.yaml
- service.yaml

patches:
#- non-olm-patches/cainjection_in_argocds.yaml
#- non-olm-patches/cainjection_in_service.yaml
#- non-olm-patches/vol_in_deployment.yaml

configurations:
- kustomizeconfig.yaml
4 changes: 2 additions & 2 deletions controllers/argocd/role_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func TestReconcileArgoCD_reconcileRole(t *testing.T) {
assert.NoError(t, createNamespace(r, a.Namespace, ""))
assert.NoError(t, createNamespace(r, "newNamespaceTest", a.Namespace))

workloadIdentifier := common.ArgoCDApplicationControllerComponent
workloadIdentifier := common.ArgoCDApplicationControllerComponent
expectedRules := policyRuleForApplicationController()
_, err := r.reconcileRole(workloadIdentifier, expectedRules, a)
assert.NoError(t, err)
Expand Down Expand Up @@ -231,7 +231,7 @@ func TestReconcileRoles_ManagedTerminatingNamespace(t *testing.T) {
// Create a managed namespace
assert.NoError(t, createNamespace(r, "managedNS", a.Namespace))

workloadIdentifier := common.ArgoCDApplicationControllerComponent
workloadIdentifier := common.ArgoCDApplicationControllerComponent
expectedRules := policyRuleForApplicationController()
_, err := r.reconcileRole(workloadIdentifier, expectedRules, a)
assert.NoError(t, err)
Expand Down

0 comments on commit ffc9633

Please sign in to comment.