test: Add test for notification service with self-signed certs #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svghadi
commented
Nov 27, 2023
| spec: | ||
| containers: | ||
| - name: server | ||
| image: quay.io/svghadi/webhook-server:latest |
There was a problem hiding this comment.
Should we move this image to quay.io/argoprojlabs/ similar to quay.io/argoprojlabs/argocd-notifications-e2e-smtplistener:multiarch which is used in 1-022_validate_notifications?
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
What does this PR do / why we need it:
This PR adds a e2e test for argoproj/argo-cd#15392. The bug has been fixed in upstream argocd with argoproj/argo-cd#15394.
The source for
webhook-serverimage used in test is added intotests/auxiliary/webhook-server. The self-signed certs are generated on linux and are valid forwebhookendpoint till2103year.How to test changes / Special notes to the reviewer:
Run automated kuttl test
kubectl kuttl test tests/k8s --config tests/kuttl-tests.yaml --test 1-034_validate_webhook_notifications