Fix issue in extraCommandArgs field

[Rizwana777]

JIRA - https://issues.redhat.com/browse/GITOPS-5200

[saumeya]

What if an existing flag is added with a new value, will that also be skipped?

[Rizwana777]

yes, it is skipped

[saumeya]

Is that the expected behavior? what if the user wants to change the current flag value?

[Rizwana777]

based on the existing unit test https://github.com/argoproj-labs/argocd-operator/blob/master/controllers/argocd/deployment_test.go#L1304 which is updating existing cmd i.e --redis command, I think this is expected behaviour, I might be wrong and open for suggestions

[saumeya]

Ok, maybe we can confirm with others as well. Otherwise looks good.

[svghadi]

I think users should be allowed to override default flags. There may be cases where tuning of default params could be useful.

[jopit]

I don't see any logic to address the 3rd problem reported in the Jira issue

3. Adding argument and value as a single element causes the pod to crash

Other than that, it looks good to me.

[Rizwana777]

I don't see any logic to address the 3rd problem reported in the Jira issue

3. Adding argument and value as a single element causes the pod to crash

Other than that, it looks good to me.

Thanks John, for 3rd point -

Pod crashes as mentioned in description because ,

'{.spec.server.extraCommandArgs}' ["foo bar"] , here extraCommandArgs is of type []string and we need to pass the flag value i.e, foo as --foo and bar as value like this ["--foo" "bar"] , if we pass values as mentioned pod will not crash, 
and pod crashes as mentioned in description is :
error : Error: unknown flag: --foo
Usage:
argocd-server [flags]
argocd-server [command], as --foo is a flag and we can use available flags

[Rizwana777]

FAIL: kuttl/harness/1-036_validate_role_rolebinding_for_source_namespace this e2e test is failing in other PRs as well

[saumeya]

Re-ran the tests

[Rizwana777]

FAIL: kuttl/harness/1-036_validate_role_rolebinding_for_source_namespace this e2e test is failing in other PRs as well

All the tests are passing now

[svghadi]

@Rizwana777 - Can we allow users to override params? There may be cases where tuning of default params could be useful.