Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't create SA for Admin and View aggregated ClusterRoles #1551

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

jparsai
Copy link
Collaborator

@jparsai jparsai commented Oct 1, 2024

What type of PR is this?
/kind bug

What does this PR do / why we need it:
This PR is to avoid creation of Service Accounts for Admin and View aggregated ClusterRoles.

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwest jgwest merged commit 8808099 into argoproj-labs:master Oct 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants